Are these shorts too long?

I think those shorts are too short. You want this guy to like you for the wrong reasons. If he really likes you, he will think you are beautiful regardless of what you wear. You're sending out the wrong message and should focus on winning him over with your great personality. If all else fails than he isn't the guy for you.